gh-139842: Clarify __module__ description in typing.rst
#139863
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `__module__` attribute must be a string or `None`, not an actual module instance. See python#139842.
|
All commit authors signed the Contributor License Agreement. |
ZeroIntensity
approved these changes
Oct 9, 2025
AlexWaygood
added
needs backport to 3.13
|
Thanks @pawamoy for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 9, 2025
…onGH-139863) (cherry picked from commit f575dd9) Co-authored-by: Timothée Mazzucotelli <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 9, 2025
…onGH-139863) (cherry picked from commit f575dd9) Co-authored-by: Timothée Mazzucotelli <[email protected]>
|
GH-139869 is a backport of this pull request to the 3.14 branch. |
|
GH-139870 is a backport of this pull request to the 3.13 branch. |
AlexWaygood
pushed a commit
that referenced
this pull request
Oct 9, 2025
…139863) (#139870) Co-authored-by: Timothée Mazzucotelli <[email protected]>
AlexWaygood
pushed a commit
that referenced
this pull request
Oct 9, 2025
…139863) (#139869) Co-authored-by: Timothée Mazzucotelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__module__attribute must be a string orNone, not an actual module instance. Make it clear in the__module__attribute description, and consistent with other occurrences throughout the docs.Fixes #139842.
__module__#139842📚 Documentation preview 📚: https://cpython-previews--139863.org.readthedocs.build/