Skip to content

gh-139817: Attribute __qualname__ is added to TypeAliasType #139919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 15, 2025
Merged

gh-139817: Attribute __qualname__ is added to TypeAliasType #139919

merged 8 commits into from
Oct 15, 2025
+144 −33

Conversation

efimov-mikhail
Copy link
Contributor

@efimov-mikhail efimov-mikhail commented Oct 10, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 10, 2025
Closed
@efimov-mikhail efimov-mikhail changed the title gh-139817: Parameter __qualname__ is added to TypeAliasType gh-139817: Attribute __qualname__ is added to TypeAliasType Oct 10, 2025
@efimov-mikhail
Copy link
Contributor Author

CC @sobolevn

@efimov-mikhail
Copy link
Contributor Author

I'm totally not sure that this solution is fully correct.
But it works in typical situations, and improves introspection.

JelleZijlstra
JelleZijlstra reviewed Oct 11, 2025
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@efimov-mikhail
Copy link
Contributor Author

I've added some tests on __name__ and __qualname__, docs and news

@AlexWaygood AlexWaygood removed their request for review October 11, 2025 23:56
JelleZijlstra
JelleZijlstra reviewed Oct 12, 2025
View reviewed changes
@efimov-mikhail
Copy link
Contributor Author

I've added new constructor parameter: X = TypeAliasType("X", int, qualname="foo.X"). It looks like there is no much extra complexity and this solution is OK. But we can provide another variant, if it's needed.

JelleZijlstra
JelleZijlstra reviewed Oct 12, 2025
View reviewed changes
@efimov-mikhail efimov-mikhail mentioned this pull request Oct 12, 2025
Merged
@efimov-mikhail
Copy link
Contributor Author

efimov-mikhail commented Oct 15, 2025 •
edited
Loading

Sorry for ping, @JelleZijlstra.

This PR could be merged, or I've missed something?

@JelleZijlstra JelleZijlstra merged commit f673f0e into python:main Oct 15, 2025
45 checks passed
@efimov-mikhail
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@efimov-mikhail @JelleZijlstra