GH-139979: Add @force_not_colorized_test_class to TestOptionalHelpVersionActions #139980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savannahostrowski
added
skip issue
needs backport to 3.14
savannahostrowski
changed the title
hugovk
approved these changes
Oct 12, 2025
|
Thanks @savannahostrowski for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 12, 2025
…elpVersionActions (pythonGH-139980) (cherry picked from commit 0fc5c56) Co-authored-by: Savannah Ostrowski <[email protected]>
|
GH-140005 is a backport of this pull request to the 3.14 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TestOptionalsHelpVersionActionstest class is missing the@force_not_colorized_test_class decorator, causing test failures when running in terminals with TERM set and stdout as a TTY, as the tests expect plain text output.I think this was missed in #136809
@force_not_colorized_test_class decoratortoTestOptionalHelpVersionActions#139979