gh-135801: Improve filtering by module in warn_explicit() without module argument #140151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we need the code for Python and C implementations of |
serhiy-storchaka
force-pushed
the
warn_explicit-no-module
branch
from
a0aeb4f to
50be3cc
Compare
…ut module argument * Try to match the module name pattern with module names constructed starting from different parent directories of the filename. E.g., for "/path/to/package/module" try to match with "path.to.package.module", "to.package.module", "package.module" and "module". * Ignore trailing "/__init__.py". * Ignore trailing ".py" on Windows. * Keep matching with the full filename (without optional ".py" extension) for compatibility. * Only ignore the case of the ".py" extension on Windows.
serhiy-storchaka
force-pushed
the
warn_explicit-no-module
branch
from
649c884 to
f37f14c
Compare
serhiy-storchaka
requested review from
AA-Turner,
Eclips4,
brettcannon,
ericsnowcurrently,
ncoghlan,
tomasr8 and
warsaw
as code owners
|
Ready for review. |
serhiy-storchaka
force-pushed
the
warn_explicit-no-module
branch
from
5aaff03 to
bc5981e
Compare
serhiy-storchaka
force-pushed
the
warn_explicit-no-module
branch
from
ff502b6 to
c0b9a69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/__init__.py".