Skip to content

Conversation

encukou
Copy link
Member

@encukou encukou commented Oct 15, 2025

... And add Stan as contributor:

Co-authored-by: Stan Ulbrych <[email protected]>
Comment on lines +1029 to +1031
An extension module that is part of the :term:`standard library`, but
may be missing in some builds of CPython, usually due to missing
third-party libraries.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
An extension module that is part of the :term:`standard library`, but
may be missing in some builds of CPython, usually due to missing
third-party libraries.
An :term:`extension module` that is part of the :term:`standard library`,
but may be absent in some builds of CPython, usually due to missing
third-party libraries.

Two suggestions:

  1. Link to the glossary term.
  2. "absent" rather than "missing"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to link the CPython term too?

@StanFromIreland
Copy link
Member

pre-commit install is handy :-)

Comment on lines +48 to +49
Requirements for Optional Modules
---------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use sentence case for headers:

https://devguide.python.org/documentation/style-guide/#capitalization

Suggested change
Requirements for Optional Modules
---------------------------------
Requirements for optional modules
---------------------------------


.. versionchanged:: 3.7
Thread support and OpenSSL 1.0.2 are now required.
OpenSSL 1.0.2 are now required for :mod:`hashlib`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OpenSSL 1.0.2 are now required for :mod:`hashlib`.
OpenSSL 1.0.2 is now required for :mod:`hashlib`.


For applications that require data compression, the functions in this module
allow compression and decompression, using the zlib library. The zlib library
has its own home page at https://www.zlib.net. zlib 1.2.2.1 is the minium
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keeping the homepage link?

- 1.4.5
- :mod:`compression.zstd`

.. [1] If *libmpdec* is not available, CPython will use a bundled copy.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

5 participants