Lib/idlelib: remove commented out duplicate code
#140259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanFromIreland
added
skip issue
skip news
type-refactor
terryjreedy
added
needs backport to 3.13
|
I added most of the duplicated code and all of the comment in PR #104463, which was mostly about editing 2 other files. I changed 'package_tests' to 'module_tests' from the original code. I don't remember why but must have wanted to be able to experiment further without losing the near original, and forgot to remove it. Thanks for the PR. |
|
Thanks @StanFromIreland for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 19, 2025
…ode (pythonGH-140259) (cherry picked from commit 790cdae) Co-authored-by: Stan Ulbrych <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 19, 2025
…ode (pythonGH-140259) (cherry picked from commit 790cdae) Co-authored-by: Stan Ulbrych <[email protected]>
|
GH-140322 is a backport of this pull request to the 3.14 branch. |
|
GH-140323 is a backport of this pull request to the 3.13 branch. |
terryjreedy
pushed a commit
that referenced
this pull request
Oct 19, 2025
…icate code (GH-140259) (#140322) `Lib/idlelib/idle_test/__init__.py`: remove commented out duplicate code (GH-140259) (cherry picked from commit 790cdae) Co-authored-by: Stan Ulbrych <[email protected]>
terryjreedy
pushed a commit
that referenced
this pull request
Oct 19, 2025
…icate code (GH-140259) (#140323) `Lib/idlelib/idle_test/__init__.py`: remove commented out duplicate code (GH-140259) (cherry picked from commit 790cdae) Co-authored-by: Stan Ulbrych <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No issue. Backports merged. Done.