gh-76007: Deprecate __version__ attribute in decimal
#140302
Conversation
Co-authored-by: Victor Stinner <[email protected]>
|
(Please edit the commit message when merging so that we’re not tagged forever by pushes in clones! thanks 🙂) |
Co-authored-by: Sergey B Kirpichev <[email protected]>
Éric, all of my commits up to that point had the commit message "Commit"? I tagged you in the PR description, I don't think that should be a burden for longer than this PR is open? There is an "unsubscribe" button in the right sidebar. |
Doc/library/decimal.rst
Outdated
|
|
||
| .. versionadded:: 3.8.3 | ||
|
|
||
| .. data:: SPEC_VERSION |
There was a problem hiding this comment.
Hmm, I think that this should be moved up before "The constants in this section are only relevant for the C module." sentence of the first paragraph. Which should be also rephrased, i.e. "Following constants in <...>". Clearly, spec version is relevant for both modules.
BTW, I'm not sure about naming. Maybe more verbose "DECIMAL_SPEC_VERSION"?
There was a problem hiding this comment.
BTW, I'm not sure about naming. Maybe more verbose "DECIMAL_SPEC_VERSION"?
I have a similar sentiment, I simply used this since it was in the discussion.
It seems core devs sometimes use PR descriptions for commit messages. So, it's rather a reminder for one, who will merge this pr. |
There was a problem hiding this comment.
I'm not sure also about naming for the constant. But lets see what other people think.
decimal.SPEC_VERSION is fine by me. Skip also suggested it at #76007 (comment).
Co-authored-by: Hugo van Kemenade <[email protected]>
Per discussion in the issue, provide a
SPEC_VERSIONconstant instead. CC @merwok @smontanaro📚 Documentation preview 📚: https://cpython-previews--140302.org.readthedocs.build/