Skip to content

gh-140131: Fix REPL cursor position on Windows when module completion suggestion line hits console width #140333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

gh-140131: Fix REPL cursor position on Windows when module completion suggestion line hits console width #140333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
696a4ec
Fix REPL cursor position on Windows when module completion suggestion…
tanloong Oct 19, 2025
fe459b8
blurb
tanloong Oct 19, 2025
ea21571
Ensure storing the actual cursor column
tanloong Oct 20, 2025
5c0593b
Add test
tanloong Oct 20, 2025
742096d
Remove irrelevant self.dch1 comment and unused px_pos variable
tanloong Oct 20, 2025
3c3d0aa
Revert unrelated change "Remove irrelevant self.dch1 comment and unus…
tanloong Oct 20, 2025
939cb99
Merge branch 'main' into fix-repl-cursor-pos-windows-module-completion
tanloong Oct 20, 2025
4503176
Remove unused import
tanloong Oct 20, 2025
1dc243b
Remove another unused import
tanloong Oct 20, 2025
53b1314
Current fix breaks other tests, revert all changes
tanloong Oct 20, 2025
f776e93
Write newline to let wrapping take effect
tanloong Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Lib/_pyrepl/windows_console.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ def __write_changed_line(
self.__write(newline[x_pos:])
if wlen(newline) == self.width:
# If we wrapped we want to start at the next line
self.__write("\r\n")
self._move_relative(0, y + 1)
self.posxy = 0, y + 1
else:
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Windows/2025-10-19-23-44-46.gh-issue-140131.AABF2k.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix REPL cursor position on Windows when module completion suggestion line
hits console width.
Loading