Skip to content

Conversation

jepler
Copy link
Contributor

@jepler jepler commented Oct 20, 2025

I searched across the Lib directory of CPython and removed or re-worded outdated comments.

For instance, the private _is_text_encoding was not in fact removed in Python 3.5 but is still used by the implementation.

The _clamp property of Decimal context objects actually was removed in Python 3.3, but a test for its removal (with outdated comment) still only speculated about its eventual removal.

@python-cla-bot
Copy link

python-cla-bot bot commented Oct 20, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@terryjreedy
Copy link
Member

My opinions
codecs: yes
idlelib: please revert for now
logging: maintainer should have last say, but OK by me. Does the handlers doc have 'new in 3.2' note?
readline: yes
async test: yes
decimal test: yes
wsgiref handlers: yes

@vsajip
Copy link
Member

vsajip commented Oct 20, 2025

I'm fine with the change to logging. The versionadded is there in the docs for QueueHandler.

@jepler
Copy link
Contributor Author

jepler commented Oct 20, 2025

idlelib: please revert for now

I'm happy to do this if it makes it easier to get the rest in. But, can you say more about why, please? Tcl 8.7 is from 2007 so it seemed to me like ancient history not worth mentioning in code comments.

.. and update link to related discussion to point to github.
@jepler jepler force-pushed the outdated-comments branch from 61da7ab to 938d245 Compare October 20, 2025 14:08
@StanFromIreland
Copy link
Member

Tcl 8.7

Per the configure page, we still support building with it.

@jepler jepler force-pushed the outdated-comments branch from 938d245 to 76d2fce Compare October 20, 2025 15:35
@jepler
Copy link
Contributor Author

jepler commented Oct 20, 2025

I rebased & removed the change to idlelib.

@StanFromIreland
Copy link
Member

Please don't force push in the future, it makes reviewing harder.

@jepler
Copy link
Contributor Author

jepler commented Oct 20, 2025

Sorry, I'm still learning the norms here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants