gh-140123: Make ElementTree.find use registered global namespaces #140364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
ElementTree.find, findall, findtext, and iterfind now use the global _namespace_map as fallback when no namespaces argument is provided. Fixes inconsistencies between ElementTree and ElementPath when using ET.register_namespace.
…izer (pythonGH-140123) The namespace prefix resolution in ElementPath.xpath_tokenizer now properly uses globally registered namespaces after trying local namespaces first. This ensures consistent namespace handling across both Python and C implementations.
- Remove duplicate import of xml.etree.ElementTree as ET - Add missing newline at end of NEWS entry file
sangampaudel530
requested review from
a team,
AA-Turner,
AlexWaygood,
JelleZijlstra,
brettcannon,
ericsnowcurrently,
lysnikolaou,
ncoghlan,
pablogsal,
warsaw and
willingc
as code owners
ElementTree.find, findall, findtext, and iterfind now use the global _namespace_map as fallback when no namespaces argument is provided. Fixes inconsistencies between ElementTree and ElementPath when using ET.register_namespace.
…izer (pythonGH-140123) The namespace prefix resolution in ElementPath.xpath_tokenizer now properly uses globally registered namespaces after trying local namespaces first. This ensures consistent namespace handling across both Python and C implementations.
- Remove duplicate import of xml.etree.ElementTree as ET - Add missing newline at end of NEWS entry file
sangampaudel530
force-pushed
the
gh-140123-fix-elementtree-namespaces
branch
from
18a22ac to
8c6a6e4
Compare
Fix issue where self.parser was incorrectly initialized in XMLParser.__init__. The parser was being created twice and the wrong instance was being assigned. Now both self.parser and self._parser point to the same parser instance, maintaining backward compatibility and fixing the AttributeError in tests.
Member
|
Can I ask why I was added as a reviewer to this PR, @sangampaudel530 ? |
Member
|
I think it was an automatic CODEOWNER request due to a bad merge commit (https://github.com/python/cpython/commits/18a22ac9ca08fe8935768c4cc8e22dc141d52c9b), subsequently overwritten by force push. A |
AA-Turner
removed request for
a team,
AA-Turner,
JelleZijlstra,
brettcannon,
ericsnowcurrently,
lysnikolaou,
ncoghlan,
pablogsal,
warsaw and
willingc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ElementTree.find, findall, findtext, and iterfind now use the global _namespace_map as fallback when no namespaces argument is provided. This fixes inconsistencies between ElementTree and ElementPath when using ET.register_namespace.
Example usage:
import xml.etree.ElementTree as ET
ET.register_namespace('h', 'http://www.w3.org/TR/html4/')
tree = ET.parse('xml/example.xml')
tree.find('.//h:title') # now works without manually passing namespaces