gh-140389: fixed touchpad horizontal scrolling in IDLE editor #140390
+32
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the typos I made in the tests I created and wasting GitHub resources. I was sure I ran them but I must have screwed up. Fixed them now and they should work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IDLE doesn't have a horizontal scrollbar but that shouldn't stop the user from using their trackpad/touchpad to horizontally scroll the text. This is a small bug that can sometimes annoy people
Previously
If you try to scroll horizontally using a trackpad/touchpad, the text in IDLE would scroll vertically.
Summary of changes
<tkinter.Event>.state)Testing
I tested the issue and the fix on: Windows 11, Ubuntu 24.04 and Debian 13. The issue appears on all OSes and the fix works on all of them. While I am not 100% sure if this will break on MacOS, I am very confident that there will be no problems.
Fixes #140389