Skip to content

gh-116738: Add critical section to dbm/gdbm context manager #140391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

gh-116738: Add critical section to dbm/gdbm context manager #140391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Modules/_dbmmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,8 +515,12 @@ dbm__enter__(PyObject *self, PyObject *Py_UNUSED(dummy))
static PyObject *
dbm__exit__(PyObject *self, PyObject *Py_UNUSED(args))
{
PyObject *result;
dbmobject *dp = dbmobject_CAST(self);
return _dbm_dbm_close_impl(dp);
Py_BEGIN_CRITICAL_SECTION(self);
result = _dbm_dbm_close_impl(dp);
Py_END_CRITICAL_SECTION();
return result;
}

static PyMethodDef dbm_methods[] = {
Expand Down
6 changes: 5 additions & 1 deletion Modules/_gdbmmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,11 @@ gdbm__enter__(PyObject *self, PyObject *args)
static PyObject *
gdbm__exit__(PyObject *self, PyObject *args)
{
return _gdbm_gdbm_close_impl((gdbmobject *)self);
PyObject *result;
Py_BEGIN_CRITICAL_SECTION(self);
result = _gdbm_gdbm_close_impl((gdbmobject *)self);
Py_END_CRITICAL_SECTION();
return result;
}

static PyMethodDef gdbm_methods[] = {
Expand Down
Loading