gh-83714: Check for struct statx members in configure #140402
Merged
+92
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some systems have the definitions of the mask bits without having the corresponding members in struct statx. Add configure checks for members added after Linux 4.11 (when statx itself was added).
jbosboom
requested review from
AA-Turner,
corona10,
emmatyping and
erlend-aasland
as code owners
|
#140185 was skip-news so I assume this is also skip-news. |
|
LGTM. Merged, thank you. |
Yep, builds fine now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some systems have the definitions of the mask bits without having the corresponding members in struct statx. Add configure checks for members added after Linux 4.11 (when statx itself was added).
Here's a bug report to qemu regarding
stx_mnt_idbeing missing. The reporter has the proper kernel userspace API header withstx_mnt_id, but it's not being used for some reason. util-linux got a similar report. (Credit to @zooba for finding these reports.)cc @vstinner
cc @zooba for reporting they have a system with this problem -- would appreciate if you tested that this builds for you
statx(2)system call on Linux for extendedos.statinformation #83714📚 Documentation preview 📚: https://cpython-previews--140402.org.readthedocs.build/