-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
Docs: fix ogp_custom_meta_tags should be a list. #140424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you using the latest version of sphinxext-opengraph
? See sphinx-doc/sphinxext-opengraph#141, this was resolved in 0.13.
A
When you're done making the requested changes, leave the comment: |
Per the documentation, it has to be |
The build now fails:
|
With tuples I get: ```pytb Traceback (most recent call last): File "/home/mdk/src/python/python-docs-fr/.venv/lib/python3.13/site-packages/sphinx/events.py", line 404, in emit results.append(listener.handler(self.app, *args)) ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^ File "/home/mdk/src/python/python-docs-fr/.venv/lib/python3.13/site-packages/sphinxext/opengraph/__init__.py", line 266, in html_page_context context["metatags"] += get_tags(app, context, doctree, app.config) ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/mdk/src/python/python-docs-fr/.venv/lib/python3.13/site-packages/sphinxext/opengraph/__init__.py", line 250, in get_tags [make_tag(p, c) for p, c in tags.items()] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + [make_tag(p, c, "name") for p, c in meta_tags.items()] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + config["ogp_custom_meta_tags"] ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ TypeError: can only concatenate list (not "tuple") to list ```
5dbf4bf
to
a4c0034
Compare
#140425 -- I forgot to update the requirement in CPython, sorry. A |
Checking that.
Ohhh it changed then.
OOKKK :))) |
With tuples I get a sphinx warning:
followed by a crash:
📚 Documentation preview 📚: https://cpython-previews--140424.org.readthedocs.build/