Skip to content

gh-140381: Handle slower machines in test_profiling #140460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+25 −6
Open

gh-140381: Handle slower machines in test_profiling #140460

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f18889
gh-140381: Handle slower machines in test_profiling
stefanor Oct 22, 2025
4425705
Move is_slow_machine to test_support
stefanor Oct 22, 2025
4779da2
Tidy imports
stefanor Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions Lib/test/test_profiling/test_sampling_profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import subprocess
import sys
import tempfile
import timeit
import unittest
from collections import namedtuple
from unittest import mock
Expand All @@ -29,6 +30,8 @@

PROCESS_VM_READV_SUPPORTED = False

SLOW_MACHINE = timeit.timeit("2*2", number=10_000) > 0.0001

try:
from _remote_debugging import PROCESS_VM_READV_SUPPORTED
import _remote_debugging
Expand Down Expand Up @@ -1754,6 +1757,7 @@ def main_loop():
'''

def test_sampling_basic_functionality(self):
duration_sec = 10 if SLOW_MACHINE else 2
with (
test_subprocess(self.test_script) as subproc,
io.StringIO() as captured_output,
Expand All @@ -1762,7 +1766,7 @@ def test_sampling_basic_functionality(self):
try:
profiling.sampling.sample.sample(
subproc.process.pid,
duration_sec=2,
duration_sec=duration_sec,
sample_interval_usec=1000, # 1ms
show_summary=False,
)
Expand Down Expand Up @@ -1904,7 +1908,10 @@ def test_sample_target_script(self):
script_file.flush()
self.addCleanup(close_and_unlink, script_file)

test_args = ["profiling.sampling.sample", "-d", "1", script_file.name]
duration = 10 if SLOW_MACHINE else 1
test_args = [
"profiling.sampling.sample", "-d", str(duration), script_file.name
]

with (
mock.patch("sys.argv", test_args),
Expand Down Expand Up @@ -1936,7 +1943,12 @@ def test_sample_target_module(self):
with open(module_path, "w") as f:
f.write(self.test_script)

test_args = ["profiling.sampling.sample", "-d", "1", "-m", "test_module"]
duration = 10 if SLOW_MACHINE else 1
test_args = [
"profiling.sampling.sample",
"-d", str(duration),
"-m", "test_module"
]

with (
mock.patch("sys.argv", test_args),
Expand Down
Loading