-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
gh-140474: Fix memory leak in array.array
#140478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sergey-miryanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ZeroIntensity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The core fix looks good, but please add a test stressing this. We can remove it when we remove the u type code in 3.16.
Misc/NEWS.d/next/Library/2025-10-22-20-52-13.gh-issue-140474.xIWlip.rst
Outdated
Show resolved
Hide resolved
|
This seems to be present in 3.13 and 3.14. |
|
Thanks @StanFromIreland for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
(cherry picked from commit aa9d0a6) Co-authored-by: Stan Ulbrych <[email protected]>
(cherry picked from commit aa9d0a6) Co-authored-by: Stan Ulbrych <[email protected]>
|
GH-140498 is a backport of this pull request to the 3.14 branch. |
|
GH-140499 is a backport of this pull request to the 3.13 branch. |
…0498) gh-140474: Fix memory leak in `array.array` (GH-140478) (cherry picked from commit aa9d0a6) Co-authored-by: Stan Ulbrych <[email protected]>
…0499) gh-140474: Fix memory leak in `array.array` (GH-140478) (cherry picked from commit aa9d0a6) Co-authored-by: Stan Ulbrych <[email protected]>
Four bytes is four bytes :-)