Skip to content

gh-120057: add os.reload_environ to __all__ #140763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 29, 2025
Merged

gh-120057: add os.reload_environ to __all__ #140763

merged 4 commits into from
Oct 29, 2025

Conversation

@guoci
Copy link
Contributor

@guoci guoci commented Oct 29, 2025 •
edited by bedevere-app bot
Loading

@StanFromIreland
Copy link
Member

StanFromIreland commented Oct 29, 2025

This should have a NEWS entry IMO.

@AlexWaygood AlexWaygood changed the title add os.reload_environ to __all__ gh-120057: add os.reload_environ to __all__ Oct 29, 2025
@bedevere-app bedevere-app bot mentioned this pull request Oct 29, 2025
Closed
@AlexWaygood AlexWaygood added the needs backport to 3.14 bugs and security fixes label Oct 29, 2025
AlexWaygood
AlexWaygood reviewed Oct 29, 2025
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I agree this should have a NEWS entry.

Cc. @vstinner as author of #126268.

We could consider adding a test for the os module like this one for inspect, to make sure that __all__ is kept up-to-date in the future:

cpython/Lib/test/test_inspect/test_inspect.py

Lines 125 to 126 in 8706167

def test__all__(self):
support.check__all__(self, inspect, not_exported=("modulesbyfile",), extra=("get_annotations",))

But that can be done as a standalone change; it doesn't need to be done here IMO

@AlexWaygood AlexWaygood self-assigned this Oct 29, 2025
AlexWaygood
AlexWaygood approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@AlexWaygood AlexWaygood force-pushed the append_os_reload_environ_to_dunder_all branch from 53efc2a to 40331e6 Compare October 29, 2025 16:21
@AlexWaygood AlexWaygood enabled auto-merge (squash) October 29, 2025 16:21
@StanFromIreland
Copy link
Member

StanFromIreland commented Oct 29, 2025

CI failure is unrelated, I will rerun when possible.

vstinner
vstinner approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Well spotted, I forgot about __all__ when I added the function.

@AlexWaygood
Copy link
Member

AlexWaygood commented Oct 29, 2025

ARM workers are currently down across all GitHub, which apparently means that no CPython PRs can currently be merged https://www.githubstatus.com/

@vstinner
Copy link
Member

vstinner commented Oct 29, 2025

I reran the failing ARM jobs. Let's see if GHA feels better yet or not.

@AlexWaygood AlexWaygood merged commit b85e10f into python:main Oct 29, 2025
261 of 280 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Oct 29, 2025

Thanks @guoci for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 29, 2025
@guoci @StanFromIreland
@AlexWaygood @miss-islington
pythongh-120057: add os.reload_environ to __all__ (pythonGH-140763)
37027ce 
(cherry picked from commit b85e10f)

Co-authored-by: Guo Ci <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 29, 2025

GH-140773 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 29, 2025
AlexWaygood added a commit that referenced this pull request Oct 29, 2025
@miss-islington @guoci
@StanFromIreland @AlexWaygood
[3.14] gh-120057: add os.reload_environ to __all__ (GH-140763) (#…
6e70c75 
…140773)

Co-authored-by: Guo Ci <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments

@vstinner vstinner vstinner approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

@AlexWaygood AlexWaygood

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@guoci @StanFromIreland @AlexWaygood @vstinner