gh-132657: optimize PySet_Contains for frozensets
#141183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carreau
reviewed
Nov 7, 2025
eendebakpt
approved these changes
Nov 7, 2025
Contributor
eendebakpt
left a comment
eendebakpt
left a comment
There was a problem hiding this comment.
Looks good to me. Also see #132290, which also removes locks for set arguments to PySet_Contains.
kumaraditya303
force-pushed
the
set-optimize
branch
from
1e148e1 to
f550bb5
Compare
Contributor
|
Do you want to include a variation of my proposed test in testcapi/set.c ? With the proper Null checks and Pydecref of course. This will avoid regressions. |
Carreau
approved these changes
Nov 7, 2025
Contributor
Author
Would you like to propose a PR for that? That could be backported as well but since this PR is perf optimization it won't be backported. |
Carreau
pushed a commit
to Carreau/cpython
that referenced
this pull request
Nov 11, 2025
As discussed in pythongh-141183, the test suite did not test that PySet_Contains does not convert unhashable key into a frozenset. This commit adds a regression test for this behavior, to ensure that any behavior change is caught by the test suite.
Carreau
added a commit
to Carreau/cpython
that referenced
this pull request
Nov 11, 2025
As discussed in pythongh-141183, the test suite did not test that PySet_Contains does not convert unhashable key into a frozenset. This commit adds a regression test for this behavior, to ensure that any behavior change is caught by the test suite.
Carreau
added a commit
to Carreau/cpython
that referenced
this pull request
Nov 11, 2025
As discussed in pythongh-141183, the test suite did not test that PySet_Contains does not convert unhashable key into a frozenset. This commit adds a regression test for this behavior, to ensure that any behavior change is caught by the test suite.
Contributor
|
Done as #141411 |
Carreau
added a commit
to Carreau/cpython
that referenced
this pull request
Nov 11, 2025
As discussed in pythongh-141183, the test suite did not test that PySet_Contains does not convert unhashable key into a frozenset. This commit adds a regression test for this behavior, to ensure that any behavior change is caught by the test suite.
|
Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 19, 2025
…141183) (cherry picked from commit 7211a34) Co-authored-by: Kumar Aditya <[email protected]>
|
GH-141773 is a backport of this pull request to the 3.14 branch. |
nascheme
pushed a commit
that referenced
this pull request
Nov 20, 2025
… (gh-141773) (cherry picked from commit 7211a34) Co-authored-by: Kumar Aditya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid taking critical section if the object is an exact frozenset.