Skip to content

gh-145633: Refine notes on non-IEEE platforms#145845

Merged
vstinner merged 10 commits intopython:mainfrom
skirpichev:dae85c4d939-amend-docs
Mar 19, 2026
Merged

gh-145633: Refine notes on non-IEEE platforms#145845
vstinner merged 10 commits intopython:mainfrom
skirpichev:dae85c4d939-amend-docs

Conversation

@skirpichev
Copy link
Member

@skirpichev skirpichev commented Mar 12, 2026

  • we don't specify what happens on non-IEEE platforms
  • use rather PY_LITTLE_ENDIAN to get native endianness
  • mention that unpack functions don't fail in CPython
  • mention that PyFloat_Pack8 doesn't fail in CPython

📚 Documentation preview 📚: https://cpython-previews--145845.org.readthedocs.build/

* we don't specify what happens on non-IEEE platforms
* use rather PY_LITTLE_ENDIAN to get native endianness
* mention that unpack functions don't fail in CPython
* mention that PyFloat_Pack8 doesn't fail in CPython
@skirpichev
Copy link
Member Author

N.B: shouldn't be backported.

Maybe it's better to document first the PY_LITTLE_ENDIAN macro and then just reference it.

@skirpichev
Copy link
Member Author

СС @StanFromIreland

Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little grammar things.

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@skirpichev skirpichev requested a review from hugovk March 14, 2026 09:54
@hugovk hugovk changed the title gh-145633: amend dae85c4d939 (refine notes on non-IEEE platforms) gh-145633: Refine notes on non-IEEE platforms Mar 15, 2026
@skirpichev
Copy link
Member Author

CC @vstinner

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner vstinner enabled auto-merge (squash) March 19, 2026 11:37
@vstinner vstinner merged commit 52c0186 into python:main Mar 19, 2026
37 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Mar 19, 2026
@skirpichev skirpichev deleted the dae85c4d939-amend-docs branch March 19, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants