gh-146139: Disable socketpair authentication on WASI#146140
Open
dicej wants to merge 1 commit intopython:mainfrom
Open
gh-146139: Disable socketpair authentication on WASI#146140dicej wants to merge 1 commit intopython:mainfrom
socketpair authentication on WASI#146140dicej wants to merge 1 commit intopython:mainfrom
Conversation
Calling `connect(2)` on a non-blocking socket on WASI may leave the socket in a "connecting" but not yet "connected" state. In the former case, calling `getpeername(2)` on it will fail, leading to an unhandled exception in Python.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
The following commit authors need to sign the Contributor License Agreement: |
vstinner
approved these changes
Mar 19, 2026
| raise | ||
| # | ||
| # Note that we skip this on WASI because on that platorm the client socket | ||
| # may not have finished connecting by the time we've reached this point. |
Member
There was a problem hiding this comment.
Maybe refer to the issue:
Suggested change
| # may not have finished connecting by the time we've reached this point. | |
| # may not have finished connecting by the time we've reached this point (gh-146139). |
Member
|
@dicej: You should sign the Python CLA: #146140 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
connect(2)on a non-blocking socket on WASI may leave the socket in a "connecting" but not yet "connected" state. In the former case, callinggetpeername(2)on it will fail, leading to an unhandled exception in Python.socketpairauthentication is unreliable on WASI #146139