Skip to content

gh-146153: Use frozendict in pure python fallback for curses.has_key#146154

Open
jonathandung wants to merge 13 commits intopython:mainfrom
jonathandung:patch-1
Open

gh-146153: Use frozendict in pure python fallback for curses.has_key#146154
jonathandung wants to merge 13 commits intopython:mainfrom
jonathandung:patch-1

Conversation

@jonathandung
Copy link

@jonathandung jonathandung commented Mar 19, 2026

@bedevere-app
Copy link

bedevere-app bot commented Mar 19, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Mar 19, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@jonathandung jonathandung changed the title gh-146153: Use frozenmap in pure python fallback for curses.has_key gh-146153: Use frozendict in pure python fallback for curses.has_key Mar 19, 2026
@@ -0,0 +1 @@
Changed the ``_capability_names`` dictionary in :mod:`curses.has_key` to a :class:`frozendict`, since it is private and requires no modifications. Contributed by Jonathan Dung.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this change impacts end users since the dictionary is private. So I suggest removing this NEWS entry.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the skip news label

@bedevere-app
Copy link

bedevere-app bot commented Mar 19, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Mar 19, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@jonathandung jonathandung requested a review from vstinner March 19, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use frozendict in Lib/curses/has_key.py

2 participants