Skip to content

Conversation

@Forrest-J
Copy link

@Forrest-J Forrest-J commented Nov 17, 2020

Updating macOS icons to conform to the new UI and app icon guidelines.

https://bugs.python.org/issue42386

Update Folder and Disk Image
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Forrest-J

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

For Disk Image and Folder
@ronaldoussoren
Copy link
Contributor

I like the look of these icons.

It would be nice to have updated versions of the other Mac icons as well if you're up for it, but that definitely doesn't block this PR.

@Forrest-J
Copy link
Author

Forrest-J commented Nov 21, 2020

I'll try to get to the other icons when I find the time. I'll probably also have to make separate versions for the lower sizes for consistency & clarity.

@Forrest-J
Copy link
Author

On another note, there are no official production templates for Big Sur document icons since the advised method is to have them generated instead.

Per use on official site.
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 22, 2020
@Forrest-J Forrest-J marked this pull request as ready for review May 25, 2021 16:57
@Forrest-J Forrest-J requested a review from a team as a code owner May 25, 2021 16:57
erlend-aasland
erlend-aasland previously approved these changes Oct 20, 2021
@ned-deily ned-deily self-assigned this Oct 20, 2021
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 31, 2022
@arhadthedev arhadthedev changed the title bpo-42386: Update icons for macOS 11 gh-86552: Update icons for macOS 11 Feb 13, 2023
@arhadthedev
Copy link
Member

arhadthedev commented Feb 13, 2023

It would be nice to have updated versions of the other Mac icons as well if you're up for it, but that definitely doesn't block this PR.

@python/macos-team Can this PR be reviewed and possibly merged please?

@ned-deily
Copy link
Member

Sorry for the delay. I am working on a significant refactoring of our macOS installer build process for 3.12 and this, and other pending macOS installer related issues will be addressed there. @arhadthedev, thanks for your refreshes but, as these PRs will need to be updated later anyway, it would be better to avoid needless CI churn now. They are not forgotten :)

@hugovk

This comment was marked as resolved.

@python-cla-bot
Copy link

The following commit authors need to sign the Contributor License Agreement:

CLA signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants