Skip to content

bpo-42547: fix add_argument(metavar=<tuple>, nargs='+') for positional arguments #23617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

bpo-42547: fix add_argument(metavar=<tuple>, nargs='+') for positional arguments #23617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/argparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,7 @@ def _format_action(self, action):
def _format_action_invocation(self, action):
if not action.option_strings:
default = self._get_default_metavar_for_positional(action)
metavar, = self._metavar_formatter(action, default)(1)
metavar = self._metavar_formatter(action, default)(1)[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but there really needs to be a unit test for this change.

return metavar

else:
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2020-12-03-00-40-12.bpo-42547.O2BJhp.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
argparse: fixed `add_argument(metavar=<tuple>, nargs='+')` for positional arguments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more details and use full sentences. Code snippets should be enclosed in double backquotes.

Please replace "argparse" with

:mod:`argparse`