Skip to content

gh-86819: Add ISO-TP CAN socket constants #23794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 17, 2025
Merged

gh-86819: Add ISO-TP CAN socket constants #23794

merged 3 commits into from
Sep 17, 2025

Conversation

@rumpelsepp
Copy link
Contributor

@rumpelsepp rumpelsepp commented Dec 16, 2020 •
edited by bedevere-app bot
Loading

This adds constants to the socket module which are provided by the new isotp module available in Linux >= 5.10.

https://bugs.python.org/issue42653
#86819

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@rumpelsepp

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@shawnl
Copy link

shawnl commented Dec 16, 2020 •
edited
Loading

As the reporter or the original feature request this patch looks good to me.

(Although I hate autoconf magic)

@rumpelsepp
Copy link
Contributor Author

(Although I hate autoconf magic)

As do I… Is there anything else I have to adjust here? My autoreconf version seems different and it mutilates the checked in configure script.

@vstinner
Copy link
Member

Please open a new issue: https://bugs.python.org/issue10141 is closed.

@rumpelsepp rumpelsepp changed the title bpo-10141: Add constants for isotp.h which is included in Linux >= 5.10 issue42653: Add constants for isotp.h which is included in Linux >= 5.10 Dec 16, 2020
@rumpelsepp rumpelsepp changed the title issue42653: Add constants for isotp.h which is included in Linux >= 5.10 bpo-42653: Add constants for isotp.h which is included in Linux >= 5.10 Dec 16, 2020
@rumpelsepp
Copy link
Contributor Author

done

tiran
tiran previously requested changes Dec 16, 2020
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include a blurb and leave the CAN_ISOTP macro in place.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@rumpelsepp
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from tiran December 16, 2020 09:30
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 16, 2021
@tiran tiran removed their request for review April 17, 2021 21:16
@rumpelsepp
Copy link
Contributor Author

Am I supposed to do any more changes here?

@menschel menschel mentioned this pull request May 19, 2021
Closed
@rumpelsepp rumpelsepp force-pushed the isotp branch 4 times, most recently from c287165 to 0c4ed7d Compare February 28, 2022 23:47
@erlend-aasland erlend-aasland dismissed tiran’s stale review October 14, 2024 22:12

Christian's concerns were addressed: a NEWS blurb was added, and the CAN_ISOTP macro was left in place.

@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 14, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit ffae37c 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 14, 2024
@picnixz
Copy link
Member

picnixz commented Aug 22, 2025

Could you move the what's new entry to 3.15.rst instead?

@rumpelsepp rumpelsepp requested a review from AA-Turner as a code owner August 22, 2025 09:48
@picnixz
Copy link
Member

picnixz commented Aug 22, 2025

Don't forget to re-add the NEWS entry (I don't know where it disppeared)

@rumpelsepp
Copy link
Contributor Author

Your comments should be addressed now.

picnixz
picnixz reviewed Aug 22, 2025
View reviewed changes
picnixz
picnixz reviewed Aug 22, 2025
View reviewed changes
picnixz
picnixz reviewed Aug 22, 2025
View reviewed changes
@rumpelsepp rumpelsepp force-pushed the isotp branch 3 times, most recently from 3508d7e to 7fb109b Compare August 22, 2025 10:02
@rumpelsepp
Copy link
Contributor Author

@picnixz Thank you for your review. I think I have catched up with your remarks.

@erlend-aasland erlend-aasland enabled auto-merge (squash) September 17, 2025 16:54
@erlend-aasland erlend-aasland linked an issue Sep 17, 2025 that may be closed by this pull request
Expose ISO-TP Contants for Linux >= 5.10 #86819
Closed
@erlend-aasland erlend-aasland merged commit a9b6b09 into python:main Sep 17, 2025
45 checks passed
@rumpelsepp rumpelsepp mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@tiran tiran Awaiting requested review from tiran

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose ISO-TP Contants for Linux >= 5.10

10 participants

@rumpelsepp @the-knights-who-say-ni @shawnl @vstinner @bedevere-bot @menschel @picnixz @tiran @erlend-aasland @ezio-melotti