Skip to content

gh-88535: Improve syntax error for wrongly closed strings #26633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 13, 2025
Merged

gh-88535: Improve syntax error for wrongly closed strings #26633

merged 3 commits into from
Feb 13, 2025

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 9, 2021 •
edited by bedevere-app bot
Loading

@pablogsal pablogsal requested a review from lysnikolaou as a code owner June 9, 2021 22:05
@pablogsal pablogsal force-pushed the bpo-44369 branch 2 times, most recently from 11f5252 to 5c0744e Compare June 9, 2021 22:09
akulakov
akulakov reviewed Jun 10, 2021
View reviewed changes
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jul 15, 2021
@pablogsal
Copy link
Member Author

Ok, I think this is ready :) @isidentical @lysnikolaou

erlend-aasland
erlend-aasland approved these changes Oct 9, 2021
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

lysnikolaou
lysnikolaou approved these changes Oct 9, 2021
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 9, 2022
iritkatriel
iritkatriel previously requested changes Nov 23, 2022
View reviewed changes
Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has merge conflicts now.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@encukou
Copy link
Member

encukou commented Mar 25, 2024

I've rebased. This looks like a nice improvement.

I did need to modify an additional test, though -- see 36758b8. That looks like an improvement, but I'm not sure how it's related to this change.

@encukou encukou dismissed iritkatriel’s stale review March 25, 2024 13:14

No more conflicts

@pablogsal pablogsal mentioned this pull request Mar 27, 2024
Closed
@erlend-aasland erlend-aasland changed the title bpo-44369: Improve syntax error for wrongly closed strings gh-88535: Improve syntax error for wrongly closed strings Mar 27, 2024
@pablogsal pablogsal enabled auto-merge (squash) February 13, 2025 01:06
@pablogsal pablogsal merged commit 6fb5138 into python:main Feb 13, 2025
43 of 44 checks passed
@pablogsal pablogsal deleted the bpo-44369 branch February 13, 2025 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akulakov akulakov akulakov left review comments

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@isidentical isidentical isidentical approved these changes

@iritkatriel iritkatriel iritkatriel left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@pablogsal @bedevere-bot @encukou @akulakov @iritkatriel @erlend-aasland @lysnikolaou @isidentical @the-knights-who-say-ni @ezio-melotti