Skip to content

bpo-44864: Do not translate user-provided strings in ArgumentParser.add_subparsers() #27667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 24, 2024
Merged

bpo-44864: Do not translate user-provided strings in ArgumentParser.add_subparsers() #27667

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
addd1c5
bpo-44864: Do not translate user-provided strings in `ArgumentParser.…
jdetrey Aug 8, 2021
d7d279f
bpo-44864: Add NEWS entry
jdetrey Aug 24, 2021
27391df
Merge branch 'main' into fix-44864
serhiy-storchaka Sep 24, 2024
8dd8ae4
Merge branch 'main' into fix-44864
encukou Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Lib/argparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1774,8 +1774,8 @@ def add_subparsers(self, **kwargs):
kwargs.setdefault('parser_class', type(self))

if 'title' in kwargs or 'description' in kwargs:
title = _(kwargs.pop('title', 'subcommands'))
description = _(kwargs.pop('description', None))
title = kwargs.pop('title', _('subcommands'))
description = kwargs.pop('description', None)
self._subparsers = self.add_argument_group(title, description)
else:
self._subparsers = self._positionals
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2021-08-24-19-37-46.bpo-44864.KzxaDh.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Do not translate user-provided strings in :class:`argparse.ArgumentParser`.