Skip to content

gh-89562: Remove hostflags from PySSLContext #28602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

gh-89562: Remove hostflags from PySSLContext #28602

merged 1 commit into from
Apr 18, 2025

Conversation

@ramikg
Copy link
Contributor

@ramikg ramikg commented Sep 28, 2021 •
edited by bedevere-app bot
Loading

The PySSLContext struct in Modules/_ssl.c mentions that "OpenSSL has no API to get hostflags from X509_VERIFY_PARAM* struct. We have to maintain our own copy".
Since OpenSSL 1.1.0i added the function X509_VERIFY_PARAM_get_hostflags, this statement is no longer true.
Because Python 3.10 requires OpenSSL 1.1.1 (PEP 644), we no longer have to maintain a copy of the host flags.

This PR removes the hostflags member from the PySSLContext struct.

https://bugs.python.org/issue45399

@ramikg ramikg changed the title Remove hostflags from PySSLContext bpo-43669: Remove hostflags from PySSLContext Oct 7, 2021
tiran
tiran requested changes Oct 7, 2021
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bpo-43669 is closed. This PR needs a new ticket.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ramikg
Copy link
Contributor Author

ramikg commented Oct 7, 2021

bpo-43669 is closed. This PR needs a new ticket.

Is it possible to submit this PR without a bpo? (on the count of it being trivial)

@tiran
Copy link
Member

tiran commented Oct 7, 2021

bpo-43669 is closed. This PR needs a new ticket.

Is it possible to submit this PR without a bpo? (on the count of it being trivial)

No, this is not a trivial change. Python requires a ticket for every change that has even a remote chance of affecting a single user. By definition, C and OpenSSL are not trivial, too.

@ramikg ramikg changed the title bpo-43669: Remove hostflags from PySSLContext bpo-45399: Remove hostflags from PySSLContext Oct 7, 2021
@ramikg
Copy link
Contributor Author

ramikg commented Oct 7, 2021 •
edited
Loading

Understood, thank you.

@ramikg ramikg requested a review from tiran May 28, 2022 11:18
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

1 similar comment
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ramikg
Copy link
Contributor Author

ramikg commented Oct 26, 2024 •
edited
Loading

I have made the requested changes; please review again.

@bedevere-app
Copy link

bedevere-app bot commented Oct 26, 2024

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

@python-cla-bot
Copy link

python-cla-bot bot commented Apr 18, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@ramikg ramikg requested review from gpshead and picnixz as code owners April 18, 2025 19:32
@ramikg ramikg mannequin mentioned this pull request Apr 18, 2025
Closed
@picnixz picnixz changed the title bpo-45399: Remove hostflags from PySSLContext gh-89562: Remove hostflags from PySSLContext Apr 18, 2025
@gpshead gpshead merged commit 9752c84 into python:main Apr 18, 2025
45 of 46 checks passed
@gpshead gpshead self-assigned this Apr 18, 2025
@ramikg ramikg deleted the remove-hostflags-from-pysslcontext-struct branch April 19, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

@tiran tiran Awaiting requested review from tiran

@picnixz picnixz Awaiting requested review from picnixz picnixz is a code owner

Assignees

@gpshead gpshead

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ramikg @bedevere-bot @tiran @gpshead @the-knights-who-say-ni @ezio-melotti