bpo-45325: Add a new 'p' parameter to Py_BuildValue to convert an integer into a Python bool #28634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
force-pushed
the
bpo-45325
branch
from
01df4ef to
5ef0d15
Compare
vstinner
approved these changes
Sep 29, 2021
There was a problem hiding this comment.
LGTM, but it would be interested to see if/how this feature would be useful in the existing code: https://bugs.python.org/issue45325#msg402900
brandtbucher
requested changes
Oct 1, 2021
|
When you're done making the requested changes, leave the comment: And if you don't make the requested changes, you will be poked with soft cushions! |
|
This PR is stale because it has been open for 30 days with no activity. |
|
@pablogsal: Do you plan to update your PR? |
Yep, I just time :) |
github-actions
bot
removed
the
stale
ezio-melotti
reviewed
Sep 6, 2022
pablogsal
commented
Feb 13, 2025
|
@brandtbucher can you review again? |
|
I have rebased and updated the PR. |
…eger into a Python bool
brandtbucher
approved these changes
Feb 18, 2025
|
This PR was merged, but the discussion on #89488 was not finished. I have concerns that this is a dangerous feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue45325