gh-65169: Clarify prog behavior in argparse #31602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slateny
changed the title
DanielNoord
suggested changes
Jul 16, 2022
|
I believe that on merge, Github will automatically pull the co-author from the description so no need to put it in the commit message. Good point on the gh issue, I'll change them over for convenience. |
slateny
changed the title
|
@DanielNoord I have created a new PR #96983. I also mentioned both @slateny and @lilbludot on that. |
|
What's the reason for making a new PR? |
|
@asvetlov It looks like the section being updated here was written by you some 10 years ago, could you take a peek at it? |
savannahostrowski
approved these changes
Sep 14, 2024
serhiy-storchaka
approved these changes
Sep 24, 2024
serhiy-storchaka
added
needs backport to 3.12
|
Thanks @slateny for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 24, 2024
(cherry picked from commit e69ff34) Co-authored-by: Stanley <[email protected]>
|
GH-124430 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 24, 2024
(cherry picked from commit e69ff34) Co-authored-by: Stanley <[email protected]>
|
GH-124431 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Sep 24, 2024
(cherry picked from commit e69ff34) Co-authored-by: Stanley <[email protected]>
Yhg1s
pushed a commit
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the latter part of the PR, my understanding is that we have this originally:
which implies that if the program is called like
then the help message will match it, but that's inaccurate. And while symlinks were mentioned in the bpo I'm not too sure how the original would read wrong, but nonetheless the suggested rewording fits well to me so I've used it with some very minor changes.
Co-authored-by: Kinga Farkas
https://bugs.python.org/issue20970