Skip to content

gh-91400: make sure email parsing dont unquote realnames with spaces #92638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

gh-91400: make sure email parsing dont unquote realnames with spaces #92638

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fffa4e0
gh-91400: make sure email parsing dont unquote realnames with spaces
carlbordum May 10, 2022
7aa20b8
Restrict NEWS wording to the exact behavior change.
gpshead Mar 17, 2023
5723107
simplify the test
gpshead Mar 17, 2023
027aa0a
Add a comment describing the purpose of the regexes.
gpshead Mar 17, 2023
27186fe
Merge branch 'main' into 91400-formataddr
arhadthedev Apr 1, 2023
b42fa77
Merge branch 'main' into 91400-formataddr
hugovk Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/email/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
CRLF = '\r\n'
TICK = "'"

specialsre = re.compile(r'[][\\()<>@,:;".]')
specialsre = re.compile(r'[][\\()<>@,:;". ]')
escapesre = re.compile(r'[\\"]')

def _has_surrogates(s):
Expand Down
10 changes: 9 additions & 1 deletion Lib/test/test_email/test_email.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3143,7 +3143,7 @@ def test_parseaddr_multiple_domains(self):
def test_noquote_dump(self):
self.assertEqual(
utils.formataddr(('A Silly Person', '[email protected]')),
'A Silly Person <[email protected]>')
'"A Silly Person" <[email protected]>')

def test_escape_dump(self):
self.assertEqual(
Expand All @@ -3164,6 +3164,14 @@ def test_escape_backslashes(self):
b = '[email protected]'
self.assertEqual(utils.parseaddr(utils.formataddr((a, b))), (a, b))

def test_parseaddr_formataddr_inverse(self):
# gh-91400
identity = '"foo bar" <[email protected]>'
single = utils.formataddr(utils.parseaddr(identity))
double = utils.formataddr(utils.parseaddr(single))
self.assertEqual(identity, single)
self.assertEqual(single, double)

def test_quotes_unicode_names(self):
# issue 1690608. email.utils.formataddr() should be rfc2047 aware.
name = "H\u00e4ns W\u00fcrst"
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2022-05-10-21-46-28.gh-issue-91400.usUzm_.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Make email.utils.formataddr and email.utils.parseaddr inverse of each other