Skip to content

Conversation

@tomlin7
Copy link

@tomlin7 tomlin7 commented May 15, 2022

When a selection is made, add a selection label after cursor row/column labels.
While a selection is present, update it on <<set-line-and-column event>>.

tomlin7 added 2 commits May 15, 2022 20:23
- create new statusbar label called selected
- update label selected on set-line-and-column event
@tomlin7 tomlin7 requested a review from terryjreedy as a code owner May 15, 2022 17:38
@ghost
Copy link

ghost commented May 15, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@tomlin7 tomlin7 changed the title gh-#92822: Added "selected" section to IDLE statusbar gh-92822: Added "selected" section to IDLE statusbar May 15, 2022
@AlexWaygood AlexWaygood added type-feature A feature request or enhancement topic-IDLE labels May 15, 2022
@terryjreedy
Copy link
Member

I have not yet accepted the addition, let alone the format; further edits should await approval of both. See issue.

If accepted, new tests will be needed. Running tests before they are added is useless.

@terryjreedy terryjreedy changed the title gh-92822: Added "selected" section to IDLE statusbar gh-92822: IDLE - Add a selection label to window statusbars Jul 24, 2022
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change applies regardless of possible format change.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Co-authored-by: Terry Jan Reedy <[email protected]>
@tomlin7
Copy link
Author

tomlin7 commented Jul 24, 2022

@terryjreedy I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from terryjreedy July 24, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants