gh-95371: Add support for other image formats(e.g. PNG) to the turtle…

[relent95]

• Shape.__init__()
  The existing buggy and dead code calling an instance method TurtleScreen._image() as a class method was removed.(It has never been reached via turtle.register_shape())

• TurtleScreen.register_shape()
  The existing redundant code checking the filename extension was removed because the backend tkinter.PhotoImage does that.
  A new pattern for arguments, such as register_shape("turtle", "turtle.gif") was added to be consistent with cases for polygon shapes.(It will be useful when the filename is quite long, as in case of using a full path.)

• TurtleScreen.bgpic()
  This already supports other image formats. So only the documentation was changed.

• Issue: Add support for other image formats(e.g. PNG) to the turtle module #95371

[bedevere-bot]

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

[hugovk]

Some little spacing nits.

Also, any particular reason to list them in order PGM, PPM, GIF, and PNG?

I'd either put them in some sort of order of "popularity/ease of use" (e.g. "PNG, GIF, PGM, and PPM") or alphabetically ("GIF,PGM, PNG, and PPM").

[relent95]

1. Spaces were added as you suggested.
2. The list of supported formats were taken from the existing tkinter documentation(https://docs.python.org/3/library/tkinter.html). But I like your idea to list popular formats first and I did that.

[arhadthedev]

Merging main into this PR to check if #95371 (comment) is necessary:

[...] Because its base version is quite old, I can prepare a new PR if it's required.

[hugovk]

Please could you add some versionchanged or versionadded to document the changes/additions at the end of each function?

The next version will be 3.12.

Docs: https://devguide.python.org/documentation/markup/#paragraph-level-markup

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[relent95]

@adorilson @hugovk I'll continue this work. Sorry for being too late. I updated the document by adding the versionchanged information. Can you review the change?

[adorilson]

@adorilson @hugovk I'll continue this work. Sorry for being too late. I updated the document by adding the versionchanged information. Can you review the change?

Great news, @relent95 .

Now, the recommendation is that you use I have made the requested changes; please review again to the @bedevere-bot to do his work.

[hugovk]

Thanks, nearly there :)

[relent95]

@bedevere-bot I have made the requested changes; please review again.

[bedevere-app]

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

[relent95]

@bedevere-bot I have made the requested changes; please review again.

[bedevere-app]

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

[hugovk]

Thank you!