Skip to content

Conversation

@delta1513
Copy link

@delta1513 delta1513 commented Nov 7, 2022

Implemented the patchfile from BPO 28309

Fixes #72496

As also noted in the issue thread, I noticed no performance improvements on my machine so someone else may want to verify whether these changes are actually beneficial.

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost
Copy link

ghost commented Nov 7, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@AlexWaygood AlexWaygood added type-feature A feature request or enhancement performance Performance or resource usage labels Nov 7, 2022
@furkanonder
Copy link
Contributor

LGTM. @delta1513 Can you sign the the CLA and add a NEWS entry?

@delta1513
Copy link
Author

@furkanonder I just realized that my old account @delta1512 (which I have been locked-out of) managed to still be on my system and somehow make its way into the commit and it's asking me to sign with that account.

If necessary I will try and recover the account and sign the CLA, else I'm very sure that I've signed it as @delta1513 if only that is sufficient.

Let me know if there are other options that will make merging this PR easier.

As for the NEWS entry, I have it added. Please let me know if I got the format wrong or need to change anything.

I apologize for the inconvenience, I am much more accustomed to Gitlab 😅

@delta1513
Copy link
Author

delta1513 commented Feb 1, 2023

I just unlinked my old email from @delta1512 because I couldn't recover it.

Let me know if you want me to close and re-submit this PR as @delta1513 only.

Sorry about the lack of activity, totally forgot I had this open. Going to see about getting this fixed up now that this is my main account 👍

@python-cla-bot
Copy link

The following commit authors need to sign the Contributor License Agreement:

CLA signed

@uranusjr
Copy link
Contributor

Looks like the merge commit (made on GitHub?) confused the CLA bot. A local rebasee to remove the commit will probably fix it.

@delta1513
Copy link
Author

I've left this too long and I'm unable to get this working.

I think it's best someone else with more experience picks this up since I've rebased locally and a whole bunch of things have broken.

@delta1513 delta1513 closed this Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review performance Performance or resource usage type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accelerate string.Template by using formatted string literals

5 participants