Skip to content

Add instructions on how to use the dev container image from GHCR #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 26, 2025
Merged

Add instructions on how to use the dev container image from GHCR #1581

merged 8 commits into from
Jun 26, 2025

Conversation

@brettcannon
Copy link
Member

@brettcannon brettcannon commented Jun 18, 2025 •
edited by github-actions bot
Loading

Along the way make using the container outside of GitHub Codespaces its own section.

📚 Documentation preview 📚: https://cpython-devguide--1581.org.readthedocs.build/

@brettcannon
Add instructions on how to use the dev container image from GHCR
c66e9b1 
Along the way make using the container outside of GitHub Codespaces its own section.
@brettcannon brettcannon requested a review from encukou June 18, 2025 21:29
@brettcannon brettcannon mentioned this pull request Jun 18, 2025
Open
willingc
willingc approved these changes Jun 20, 2025
View reviewed changes
Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I appreciate this addition @brettcannon.

encukou
encukou reviewed Jun 21, 2025
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

hugovk
hugovk reviewed Jun 24, 2025
View reviewed changes
brettcannon and others added 5 commits June 24, 2025 10:39
@brettcannon @hugovk
Apply suggestion from @hugovk
22485d6 
Co-authored-by: Hugo van Kemenade <[email protected]>
@brettcannon @hugovk
Apply suggestion from @hugovk
7792f9b 
Co-authored-by: Hugo van Kemenade <[email protected]>
@brettcannon @encukou
Apply suggestion from @encukou
2442e01 
Co-authored-by: Petr Viktorin <[email protected]>
@brettcannon @hugovk
Apply suggestion from @hugovk
49ebe57 
Co-authored-by: Hugo van Kemenade <[email protected]>
@brettcannon @hugovk
Apply suggestion from @hugovk
bcac3a6 
Co-authored-by: Hugo van Kemenade <[email protected]>
@brettcannon
Copy link
Member Author

@hugovk @encukou you all okay with the merge after your comments?

encukou
encukou reviewed Jun 26, 2025
View reviewed changes
encukou
encukou approved these changes Jun 26, 2025
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you!
(except a ReST syntax gotcha)

hugovk
hugovk approved these changes Jun 26, 2025
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also yes, thanks!

@hugovk hugovk merged commit 8b08566 into python:main Jun 26, 2025
4 checks passed
@brettcannon brettcannon deleted the devcontainer-instructions branch June 26, 2025 18:43
@josephgruber josephgruber mentioned this pull request Sep 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes

@hugovk hugovk hugovk approved these changes

@willingc willingc willingc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brettcannon @encukou @hugovk @willingc