Use pathlib more #197
Merged
Use pathlib more #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
commented
Sep 23, 2024
Comment on lines
860
to
865
| [ | ||
| "cp", | ||
| "-a", | ||
| *[ | ||
| str(dist) | ||
| for dist in (Path(self.checkout) / "Doc" / "dist").glob("*") | ||
| ], | ||
| *(self.checkout / "Doc" / "dist").glob("*"), | ||
| target / "archives", | ||
| ] |
There was a problem hiding this comment.
run() calls str() on each item of the command list, no need to duplicate here.
hugovk
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces various things with pathlib alternatives. Helps to reduce nesting.
A