Skip to content

provide more verbosity for mismatched type types #13878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

provide more verbosity for mismatched type types #13878

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7dc1077
provide more verbosity for mismatched type types
altendky Oct 12, 2022
4e7c8cf
more specific, but passes tests
altendky Oct 12, 2022
40f0c59
filter more
altendky Oct 14, 2022
d944da7
and more picky
altendky Oct 16, 2022
11dbf6a
cleanup
altendky Oct 16, 2022
571da98
Merge branch 'master' into more_verbosity_for_mismatched_type_types
altendky Nov 23, 2022
d627e06
Merge branch 'master' into more_verbosity_for_mismatched_type_types
altendky Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions mypy/messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,6 +850,17 @@ def incompatible_argument_note(
self.report_protocol_problems(
original_caller_type, callee_type, context, parent_error=parent_error
)
if (
isinstance(callee_type, TypeType)
and isinstance(callee_type.item, Instance)
and isinstance(original_caller_type, CallableType)
and callee_type.item.type.is_protocol
):
proper_ret_type = get_proper_type(original_caller_type.ret_type)
if isinstance(proper_ret_type, Instance):
self.report_protocol_problems(
proper_ret_type, callee_type.item, context, code=code
)
if isinstance(callee_type, UnionType):
for item in callee_type.items:
item = get_proper_type(item)
Expand Down
Loading