Skip to content

Allow returning Literals in __new__ #15687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 4, 2025
Merged

Allow returning Literals in __new__ #15687

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
396e8ee
Allow returning Literals in __new__
Gobot1234 Jul 15, 2023
abbad4e
Add tests
Gobot1234 Jul 19, 2023
90b37d4
Update tests
Gobot1234 Jul 19, 2023
79cb39e
Temporarily update typeshed
Gobot1234 Jul 19, 2023
427987c
Revert "Temporarily update typeshed"
Gobot1234 Jul 19, 2023
bcaa4c9
Add reveal_types
Gobot1234 Aug 4, 2023
ec94017
Make things actually work
Gobot1234 Aug 10, 2023
dad9b05
Push what I've got
Gobot1234 Aug 10, 2023
f87fde7
Merge branch 'master' into patch-1
Gobot1234 Oct 3, 2025
c191359
Add missing object
ilevkivskyi Oct 4, 2025
535a7b1
Add type as well
ilevkivskyi Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mypy/checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1475,7 +1475,8 @@ def check___new___signature(self, fdef: FuncDef, typ: CallableType) -> None:
"but must return a subtype of",
)
elif not isinstance(
get_proper_type(bound_type.ret_type), (AnyType, Instance, TupleType, UninhabitedType)
get_proper_type(bound_type.ret_type),
(AnyType, Instance, TupleType, UninhabitedType, LiteralType),
):
self.fail(
message_registry.NON_INSTANCE_NEW_TYPE.format(
Expand Down