Skip to content

Suggest is not None Checks for Optional Attributes in Type Annotations #17836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Suggest is not None Checks for Optional Attributes in Type Annotations #17836

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8148b0a
issue 17036 solved
hemant-iitkgp Sep 26, 2024
cf0c564
issue 17036 solved
hemant-iitkgp Sep 26, 2024
682e456
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions mypy/messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,6 +534,12 @@ def has_no_attr(
context,
code=codes.UNION_ATTR,
)
if typ_format == '"None"':
self.note(
'You can use "if <variable_name> is not None" check to guard against a None value',
context,
code=codes.UNION_ATTR,
)
return codes.UNION_ATTR
elif isinstance(original_type, TypeVarType):
bound = get_proper_type(original_type.upper_bound)
Expand Down
Loading