Skip to content

Fix get_member_expr_fullname returning strings with embedded "None" #17848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2024
Merged

Fix get_member_expr_fullname returning strings with embedded "None" #17848

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cd6f87
Fix get_member_expr_fullname returning strings with embedded "None"
brianschubert Sep 28, 2024
c4c0955
Re-run test suite
brianschubert Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mypy/nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4090,7 +4090,7 @@ def get_member_expr_fullname(expr: MemberExpr) -> str | None:
initial = expr.expr.name
elif isinstance(expr.expr, MemberExpr):
initial = get_member_expr_fullname(expr.expr)
else:
if initial is None:
return None
return f"{initial}.{expr.name}"

Expand Down
Loading