Skip to content

[stubtest] Verify __all__ exists in stub #18005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 23, 2024
Merged

[stubtest] Verify __all__ exists in stub #18005

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4f907d5
[stubtest] Verify __all__ exists in stub
srittau Oct 21, 2024
4d33334
Reformat
srittau Oct 21, 2024
86a0160
Fix missing stubs functionality
srittau Oct 22, 2024
cc56ffe
Reformat (again)
srittau Oct 22, 2024
b7dc011
Merge branch 'master' into stubtest-all
srittau Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mypy/stubtest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,8 @@ def verify_mypyfile(
# Only verify the contents of the stub's __all__
# if the stub actually defines __all__
yield from _verify_exported_names(object_path, stub, runtime_all_as_set)
else:
yield Error(object_path + ["__all__"], "is not present in stub", stub, runtime)
else:
runtime_all_as_set = None

Expand Down
9 changes: 2 additions & 7 deletions mypy/test/teststubtest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1403,7 +1403,7 @@ def test_all_at_runtime_not_stub(self) -> Iterator[Case]:
runtime="""
__all__ = []
Z = 5""",
error=None,
error="__all__",
)

@collect_cases
Expand Down Expand Up @@ -1443,7 +1443,7 @@ def h(x: str): ...
runtime="",
error="h",
)
yield Case(stub="", runtime="__all__ = []", error=None) # dummy case
yield Case(stub="", runtime="__all__ = []", error="__all__") # dummy case
yield Case(stub="", runtime="__all__ += ['y']\ny = 5", error="y")
yield Case(stub="", runtime="__all__ += ['g']\ndef g(): pass", error="g")
# Here we should only check that runtime has B, since the stub explicitly re-exports it
Expand Down Expand Up @@ -2435,11 +2435,6 @@ def test_output(self) -> None:
assert output == expected

def test_ignore_flags(self) -> None:
output = run_stubtest(
stub="", runtime="__all__ = ['f']\ndef f(): pass", options=["--ignore-missing-stub"]
)
assert output == "Success: no issues found in 1 module\n"

output = run_stubtest(stub="", runtime="def f(): pass", options=["--ignore-missing-stub"])
assert output == "Success: no issues found in 1 module\n"

Expand Down
Loading