PR for beginner issue #17036

[Snehaaa24]

Added hints for None when union may not have been narrowed #17036
Please let me know if this issue still needs resolution, as it was originally raised in March 2024.

[github-actions]

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

[sterliakov]

This doesn't seem related to #17036, are you certain the issue number is correct?

[Snehaaa24]

This doesn't seem related to #17036, are you certain the issue number is correct?

yes, the issue was -Better error message when union may not have been narrowed #17036

[sterliakov]

Yes, and this PR does nothing related to union/none checks as far as I can tell. One edit is a rephrased comment (actually making the intent less clear, removing the reference to the problem that bit of code solves) and another edit changes a helper script not used by mypy itself (and probably completely dead and unused as it refers to python 3.5 which is long gone), providing no explanation.

[Snehaaa24]

Yes, and this PR does nothing related to union/none checks as far as I can tell. One edit is a rephrased comment (actually making the intent less clear, removing the reference to the problem that bit of code solves) and another edit changes a helper script not used by mypy itself (and probably completely dead and unused as it refers to python 3.5 which is long gone), providing no explanation.

Alright, sorry for the inconvinience caused. I misunderstood the issue. What I inferred from the issue was that whenever there's a union used add a hint stating that a "none check is required" for beginner users. But as you said, I ended up removing the important comments and the other edit was not needed as well. Thank you for your valuable feedback!