Run mypy_primer in 3.13 #18542
Merged
Run mypy_primer in 3.13 #18542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is needed for homeassistant
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
cdce8p
approved these changes
Jan 27, 2025
Collaborator
cdce8p
left a comment
cdce8p
left a comment
There was a problem hiding this comment.
Good point! Yes, I recently converted the first TypeVar defaults to the new syntax after we dropped 3.12.
I'd love it if mypy_primer could have failed earlier, or at least included a warning in the diff summary that a Syntax error occurred. Without it, the only hint to notice the wrong Python version is comparing the runtimes
/tmp/mypy_primer/new_mypy/venv/bin/mypy on core took 1.14s
Unless you know it usually takes >340s, there isn't really anything to point you towards it. Might even be more relevant as other projects start to use mypy_primer as well, like numpy.
x612skm
pushed a commit
to x612skm/mypy-dev
that referenced
this pull request
Feb 24, 2025
I think this is needed for homeassistant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is needed for homeassistant