Sync typeshed #18580
Closed
Sync typeshed #18580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Collaborator
Mypy primer hits
|
Source commit: python/typeshed@cc8ca93
This is allegedly causing large performance problems, see 13821 typeshed/8231 had zero hits on mypy_primer, so it's not the worst thing to undo. Patching this in typeshed also feels weird, since there's a more general soundness issue. If a typevar has a bound or constraint, we might not want to solve it to a Literal. If we can confirm the performance regression or fix the unsoundness within mypy, I might pursue upstreaming this in typeshed. (Reminder: add this to the sync_typeshed script once merged)
… checking: #13987 (comment) A manual cherry-pick of e437cdf.
github-actions
bot
force-pushed
the
mypybot/sync-typeshed
branch
from
830e8be to
3e4f0fb
Compare
Contributor
Author
|
Diff from mypy_primer, showing the effect of this PR on open source code: steam.py (https://github.com/Gobot1234/steam.py)
+ steam/trade.py:189: error: Argument 1 of "__mro_entries__" is incompatible with supertype "GenericAlias"; supertype defines the argument type as "Iterable[object]" [override]
+ steam/trade.py:189: note: This violates the Liskov substitution principle
+ steam/trade.py:189: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
freqtrade (https://github.com/freqtrade/freqtrade): 1.95x slower (128.2s -> 249.7s in a single noisy sample)
|
Collaborator
|
Seems python/typeshed#13450 broke the mypyc compiled test runs. Opened #18683 witch adds a new patch to partially revert it and fix the test runs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync typeshed
Source commit:
python/typeshed@cc8ca93
Note that you will need to close and re-open the PR in order to trigger CI.