Skip to content

Fix regression for user config files #18656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Fix regression for user config files #18656

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e13bc2c
Fix regression for user config files
hauntsaninja Feb 10, 2025
3005010
expand at definition site
hauntsaninja Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mypy/config_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ def _find_config_file(
break
current_dir = parent_dir

for config_file in defaults.USER_CONFIG_FILES:
for config_file in map(os.path.expanduser, defaults.USER_CONFIG_FILES):
Copy link
Collaborator

@sterliakov sterliakov Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to expand here and not early in defaults.py?

Copy link
Collaborator Author

@hauntsaninja hauntsaninja Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, if the original code had done that the bug would never have happened :-)

ret = _parse_individual_file(config_file, stderr)
if ret is None:
continue
Expand Down