Delete old meet hack from checkmember.py #18662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
ericmarkmartin
pushed a commit
to ericmarkmartin/mypy
that referenced
this pull request
Feb 19, 2025
The hack to use `meet_types(original_type, itype)` to select a correct element from a union appeared before we added proper handling of unions in various places related to `checkmember.py`. This is error prone, since `meet_types()` is one of least precise type ops (for good and bad reasons), and results in obscure bugs, see e.g. python#15600 This hack should not be needed anymore, now we have three-level information available everywhere we needed it: * `original_type` - as the name says, a type from which everything started. This is used for error messages and for plugin hooks. * `self_type` - a specific element of the union is the original type is a union. The name is because this is what will be ultimately used by `bind_self()` * `itype` the actual instance type where we look up the attribute (this will be e.g. a fallback if the `self_type` is not an instance)
ericmarkmartin
pushed a commit
to ericmarkmartin/mypy
that referenced
this pull request
Feb 19, 2025
The hack to use `meet_types(original_type, itype)` to select a correct element from a union appeared before we added proper handling of unions in various places related to `checkmember.py`. This is error prone, since `meet_types()` is one of least precise type ops (for good and bad reasons), and results in obscure bugs, see e.g. python#15600 This hack should not be needed anymore, now we have three-level information available everywhere we needed it: * `original_type` - as the name says, a type from which everything started. This is used for error messages and for plugin hooks. * `self_type` - a specific element of the union is the original type is a union. The name is because this is what will be ultimately used by `bind_self()` * `itype` the actual instance type where we look up the attribute (this will be e.g. a fallback if the `self_type` is not an instance)
x612skm
pushed a commit
to x612skm/mypy-dev
that referenced
this pull request
Feb 24, 2025
The hack to use `meet_types(original_type, itype)` to select a correct element from a union appeared before we added proper handling of unions in various places related to `checkmember.py`. This is error prone, since `meet_types()` is one of least precise type ops (for good and bad reasons), and results in obscure bugs, see e.g. python#15600 This hack should not be needed anymore, now we have three-level information available everywhere we needed it: * `original_type` - as the name says, a type from which everything started. This is used for error messages and for plugin hooks. * `self_type` - a specific element of the union is the original type is a union. The name is because this is what will be ultimately used by `bind_self()` * `itype` the actual instance type where we look up the attribute (this will be e.g. a fallback if the `self_type` is not an instance)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hack to use
meet_types(original_type, itype)to select a correct element from a union appeared before we added proper handling of unions in various places related tocheckmember.py. This is error prone, sincemeet_types()is one of least precise type ops (for good and bad reasons), and results in obscure bugs, see e.g. #15600This hack should not be needed anymore, now we have three-level information available everywhere we needed it:
original_type- as the name says, a type from which everything started. This is used for error messages and for plugin hooks.self_type- a specific element of the union is the original type is a union. The name is because this is what will be ultimately used bybind_self()itypethe actual instance type where we look up the attribute (this will be e.g. a fallback if theself_typeis not an instance)