Enable ruff SIM101 duplicate isinstance check #18679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
We already do a good job enforcing this throughout the codebase (only 1 fix was necessary); let's make it explicit to ensure we are maximizing performance and readability. |
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: Tanjun (https://github.com/FasterSpeeding/Tanjun): 1.40x faster (134.4s -> 95.9s in a single noisy sample)
|
cdce8p
approved these changes
Feb 16, 2025
Collaborator
cdce8p
left a comment
cdce8p
left a comment
There was a problem hiding this comment.
LGTM, thanks @Skylion007.
sterliakov
approved these changes
Feb 16, 2025
x612skm
pushed a commit
to x612skm/mypy-dev
that referenced
this pull request
Feb 24, 2025
Enforce no unnecessary duplicate isinstance calls (that could be merged into a tuple call).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce no unnecessary duplicate isinstance calls (that could be merged into a tuple call).