Skip to content

Restrict type of AssignmentExpr.target to NameExpr #18714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2025
Merged

Restrict type of AssignmentExpr.target to NameExpr #18714

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e5a9ae6
Restrict type of `AssignmentExpr.target`
bzoracler Feb 20, 2025
e18d83a
Restrict type of `AssignmentExpr.target` to `NameExpr`
bzoracler Feb 20, 2025
e532ccd
Switch to type-preserving `Name` copying method
bzoracler Mar 6, 2025
53777e4
Merge branch 'master' into assignment-expr-type
bzoracler Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mypy/nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2075,7 +2075,7 @@ class AssignmentExpr(Expression):

__match_args__ = ("target", "value")

def __init__(self, target: Expression, value: Expression) -> None:
def __init__(self, target: NameExpr, value: Expression) -> None:
super().__init__()
self.target = target
self.value = value
Expand Down
4 changes: 3 additions & 1 deletion mypy/treetransform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,9 @@ def visit_super_expr(self, node: SuperExpr) -> SuperExpr:
return new

def visit_assignment_expr(self, node: AssignmentExpr) -> AssignmentExpr:
return AssignmentExpr(self.expr(node.target), self.expr(node.value))
target = self.expr(node.target)
assert isinstance(target, NameExpr)
return AssignmentExpr(target, self.expr(node.value))

def visit_unary_expr(self, node: UnaryExpr) -> UnaryExpr:
new = UnaryExpr(node.op, self.expr(node.expr))
Expand Down