Enable FURB187 - avoid reverse list copy #18716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skylion007
force-pushed
the
skylion007/apply-ruff-FURB187-2025-02-21
branch
from
a7c673d to
21a28f4
Compare
Skylion007
commented
Feb 21, 2025
Skylion007
force-pushed
the
skylion007/apply-ruff-FURB187-2025-02-21
branch
from
21a28f4 to
91bf811
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
|
This now has a merge conflict. |
Contributor
Author
|
@JukkaL Merge conflict resolved |
brianschubert
approved these changes
Apr 2, 2025
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable a ruff rule that avoid copies in list reversal. Use builtin reverse method.
The builtin does an efficient stride reversal and avoids accidental copies.
This is extra helpful since the changed reverses are for perf optimization.