-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Update project metadata for PEP 639 #18821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| authors = [{name = "Jukka Lehtosalo", email = "[email protected]"}] | ||
| license = {text = "MIT"} | ||
| license = "MIT" | ||
| license-files = ["LICENSE", "mypy/typeshed/LICENSE"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should CREDITS be included here? Until now it wasn't / is even explicitly excluded in MANIFEST.in.
https://github.com/python/mypy/blob/master/CREDITS
Line 48 in 765a78f
| exclude .gitmodules CONTRIBUTING.md CREDITS ROADMAP.md action.yml .editorconfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't treated the credits file as part of the license in the past. It has only been updated very occasionally.
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JukkaL
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable. Let's remember to check that all metadata is shown correctly on PyPI after the next release.
| authors = [{name = "Jukka Lehtosalo", email = "[email protected]"}] | ||
| license = {text = "MIT"} | ||
| license = "MIT" | ||
| license-files = ["LICENSE", "mypy/typeshed/LICENSE"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't treated the credits file as part of the license in the past. It has only been updated very occasionally.
This reverts commit 836019a. Sadly, upgrading setuptools can cause some issues downstream. This is the case with Dropbox's internal codebase. Let's wait a bit longer before upgrading requirements and pyproject.toml file.
Setuptools
v77was released today which adds full support for PEP 639.https://setuptools.pypa.io/en/latest/history.html#v77-0-0
https://peps.python.org/pep-0639/
The relevant project metadata changes