Add shared checker interface to break import cycle #18878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
for more information, see https://pre-commit.ci
This comment has been minimized.
This comment has been minimized.
JukkaL
reviewed
Apr 4, 2025
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Looks good, just have questions about one change.
mypy/semanal.py
Outdated
| isinstance(item, Decorator) and item.func.abstract_status == IS_ABSTRACT | ||
| for item in defn.items | ||
| ): | ||
| pass |
Collaborator
There was a problem hiding this comment.
Is this a behaviour change? If yes, maybe add a test, or would this be better included in a separate PR if mypyc doesn't support this yet?
Member
Author
There was a problem hiding this comment.
Yeah, I didn't want to add an implementation for couple overloaded methods with many parameters, but unfortunately it didn't work with mypyc. I will put it into a separate PR.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import cycle is not a real one as
if TYPE_CHECKING: ...is used, but it would become much bigger if I start usingcheckmemberinsubtypes, essentially it would be one huge import cycle during self-checking. So I decided to do something similar we did for semantic analyzer.